First, let's prepare the marinade dressing. In a bowl, mix the oil, vinegar, pepper and sugar.
Cut the cucumber and onion into small cubes, and the herring fillet into a slightly larger cube.
Peel the potatoes and apple and cut into small cubes, chop the dill greens. Season the salad with marinade, stir and let it stand in the refrigerator for about an hour.